[release/8.0] SignalR performance: track groups per connection, remove on disconnect #53862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brennan <[email protected]>
github-actions
bot
requested review from
BrennanConroy and
halter73
as code owners
ghost
added
the
wtgodbe
approved these changes
Feb 12, 2024
dotnet-policy-service
bot
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #53486 to release/8.0
/cc @BrennanConroy @alex-jitbit
SignalR performance: track groups per connection, remove on disconnect
Description
Customer reported slow down on connection disconnect. Both 1st party and 3rd party customers have reported issues here.
Fixes #48249
Customer Impact
When lots of groups are used and connection(s) disconnect it results in significant CPU usage. The 1st party customer is currently using private reflection to fix this issue, but that is definitely not a recommended path forward.
Regression?
Risk
Code change is relatively simple. We have very similar code for an equivalent component. (RedisHublifetimeManager)
Verification
Packaging changes reviewed?